Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI pipeline document for our coordinator #13

Closed
bonomat opened this issue Jan 16, 2023 · 1 comment · Fixed by #20
Closed

CI pipeline document for our coordinator #13

bonomat opened this issue Jan 16, 2023 · 1 comment · Fixed by #20
Assignees
@bonomat
Labels
coordinator

Comments

@bonomat
Copy link
Contributor

bonomat commented Jan 16, 2023 •
edited
Loading

We want to have a clear picture of what and how things should be build.

The goal of this document is to describe the CI workflows we need and ensure that we think about them in advance.

Note: this issue covers only the coordinator while #11 covers the mobile app.
@bonomat bonomat changed the title [coordinator] define build pipeline document: instead of just creating multiple workflows for all the things we should get a clear picture of what and how things should be build. This should cover the testnet setup as well. Build pipeline document for coordinator Jan 16, 2023
@bonomat bonomat changed the title Build pipeline document for coordinator CI pipeline document for our coordinator Jan 16, 2023
@bonomat bonomat mentioned this issue Jan 16, 2023
Closed
@bonomat
Copy link
Contributor Author

bonomat commented Jan 16, 2023

I propose to not write this completely alone as the discussion on the PR can be unsatisfying. Instead, grab a sparring partner and discuss before hand.

@bonomat bonomat self-assigned this Jan 17, 2023
@bonomat bonomat mentioned this issue Jan 17, 2023
Merged
bors bot added a commit that referenced this issue Jan 25, 2023
@bors @bonomat
Merge #20
c8b5141 
20: CI Testing guidelines r=bonomat a=bonomat

The below shouldn't be that new to you as it is based on past experiences and decisions. What is new is that we should aim for a sub 10 minutes test execution. Let's see if we can achieve this :)


Initially I expected this to be more detailed but I stopped and went high-level.
Once we have #18 and #17 we can add more.

Resolves #11 
Resolves #13 

Note: I opted for asciidoc because I like the format more, however, I could not find a formatter for it which is a bid sad. 
So I'm happy to reconsider. 

Co-authored-by: Philipp Hoenisch <[email protected]>
@bors bors bot closed this as completed in 7f72452 Jan 30, 2023
holzeis added a commit that referenced this issue Oct 8, 2023
@holzeis
fix: Do not navigate during widget build
e3d8e54 
Fixes an exception thrown at navigating after receiving a payment during funding the app.

```
══╡ EXCEPTION CAUGHT BY FOUNDATION LIBRARY ╞════════════════════════════════════════════════════════
The following assertion was thrown while dispatching notifications for GoRouterDelegate:
setState() or markNeedsBuild() called during build.
This Router<Object> widget cannot be marked as needing to build because the framework is already in
the process of building widgets. A widget can be marked as needing to be built during the build
phase only if one of its ancestors is currently building. This exception is allowed because the
framework builds parent widgets before children, which means a dirty descendant will always be
built. Otherwise, the framework might not visit this widget during this build phase.
The widget on which setState() or markNeedsBuild() was called was:
  Router<Object>
The widget which was currently being built when the offending call was made was:
  FundWalletModal

When the exception was thrown, this was the stack:
#0      Element.markNeedsBuild.<anonymous closure> (package:flutter/src/widgets/framework.dart:4862:9)
#1      Element.markNeedsBuild (package:flutter/src/widgets/framework.dart:4874:6)
#2      State.setState (package:flutter/src/widgets/framework.dart:1158:15)
#3      _RouterState._handleRouterDelegateNotification (package:flutter/src/widgets/router.dart:791:5)
#4      ChangeNotifier.notifyListeners (package:flutter/src/foundation/change_notifier.dart:403:24)
#5      GoRouterDelegate.setNewRoutePath (package:go_router/src/delegate.dart:145:7)
#6      _RouterState._processParsedRouteInformation.<anonymous closure> (package:flutter/src/widgets/router.dart:753:34)
#7      SynchronousFuture.then (package:flutter/src/foundation/synchronous_future.dart:41:39)
#8      _RouterState._processRouteInformation (package:flutter/src/widgets/router.dart:745:8)
#9      _RouterState._handleRouteInformationProviderNotification (package:flutter/src/widgets/router.dart:762:5)
#10     ChangeNotifier.notifyListeners (package:flutter/src/foundation/change_notifier.dart:403:24)
#11     GoRouteInformationProvider.notifyListeners (package:go_router/src/information_provider.dart:141:11)
#12     GoRouteInformationProvider._setValue (package:go_router/src/information_provider.dart:149:7)
#13     GoRouteInformationProvider.go (package:go_router/src/information_provider.dart:171:5)
#14     GoRouter.go (package:go_router/src/router.dart:318:30)
#15     _FundWalletModalState.build (package:get_10101/features/wallet/onboarding/fund_wallet_modal.dart:68:28)
#16     StatefulElement.build (package:flutter/src/widgets/framework.dart:5409:27)
#17     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5297:15)
#18     StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5462:11)
#19     Element.rebuild (package:flutter/src/widgets/framework.dart:5016:7)
#20     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2779:19)
#21     WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:916:21)
#22     RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:360:5)
#23     SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1297:15)
#24     SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1227:9)
#25     SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:1085:5)
#26     _invoke (dart:ui/hooks.dart:170:13)
#27     PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:401:5)
#28     _drawFrame (dart:ui/hooks.dart:140:31)

The GoRouterDelegate sending notification was:
  Instance of 'GoRouterDelegate'
════════════════════════════════════════════════════════════════════════════════════════════════════
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bonomat bonomat

Labels
coordinator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI Testing guidelines get10101/10101
1 participant
@bonomat