Encoded definition paths remain unique (#29348)

GitOrigin-RevId: e0de53d21aac0ba2db641ab471b35235916dafee

src/cli/lib/components/definition/bundle.test.ts

@@ -0,0 +1,11 @@
+import { test, expect, describe } from "vitest";
+import { encodeDefinitionPath } from "./bundle.js";
+import { ComponentDefinitionPath } from "./directoryStructure.js";
+
+describe("encodeDefinitionPath", async () => {
+  test("Escaped definition paths are distinguishable from unescaped ones", () => {
+    const a = encodeDefinitionPath("foo/bar-baz" as ComponentDefinitionPath);
+    const b = encodeDefinitionPath("foo/bar_baz" as ComponentDefinitionPath);
+    expect(a).not.toEqual(b);
+  });
+});

src/cli/lib/components/definition/bundle.ts

@@ -311,16 +311,21 @@ async function findComponentDependencies(
   return { components, dependencyGraph };
 }
 
-// Each path component is less than 64 bytes and escape all a-zA-Z0-9
+// Each path component is less than 64 bytes and is limited to a-zA-Z0-9
 // This is the only version of the path the server will receive.
 export function encodeDefinitionPath(
   s: ComponentDefinitionPath,
 ): EncodedComponentDefinitionPath {
   const components = s.split(path.sep);
   return components
     .map((s) => {
-      const escaped = s.replaceAll("-", "_").replaceAll("+", "_");
-      if (escaped.length <= 64) {
+      const escaped = s
+        .replaceAll("-", "_")
+        .replaceAll("+", "_")
+        .replaceAll(" ", "_")
+        .replaceAll(".", "_");
+      if (escaped.length <= 64 && escaped === s) {
+        // If escaping lost any information then
         return escaped;
       }
       const hash = crypto.createHash("md5").update(s).digest("hex");