Merge pull request #184 from gessnerfl/feature/177_delete_rule_specif…

…ic_resources

closes #177: resources deleted. documentation updated, unused code cleaned up

docs/index.md

@@ -14,19 +14,7 @@ resource.
   * Global Application Alert Configuration - `instana_global_application_alert_config`
 * Event Settings
   * Custom Event Specification - `instana_custom_event_specification`
-    * Entity Verification Rule - `instana_custom_event_spec_entity_verification_rule`
-    * System Rule - `instana_custom_event_spec_system_rule`
-    * Threshold Rule - `instana_custom_event_spec_threshold_rule`
   * Alerting Channels - `instana_alerting_channel`
-    * Email - `instana_alerting_channel_email`
-    * Google Chat - `instana_alerting_channel_google_chat`
-    * Office 365 - `instana_alerting_channel_office_365`
-    * OpsGenie - `instana_alerting_channel_ops_genie`
-    * Pager Duty - `instana_alerting_channel_pager_duty`
-    * Slack - `instana_alerting_channel_slack`
-    * Splunk - `instana_alerting_channel_splunk`
-    * VictorOps - `instana_alerting_channel_victor_ops`
-    * Webhook - `instana_alerting_channel_webhook`
   * Alerting Config - `instana_alerting_config`
 * Settings
   * API Tokens - `instana_api_token`

instana/provider.go

@@ -62,9 +62,6 @@ func providerResources() map[string]*schema.Resource {
 	bindResourceHandle(resources, NewApplicationAlertConfigResourceHandle())
 	bindResourceHandle(resources, NewGlobalApplicationAlertConfigResourceHandle())
 	bindResourceHandle(resources, NewCustomEventSpecificationResourceHandle())
-	bindResourceHandle(resources, NewCustomEventSpecificationWithSystemRuleResourceHandle())
-	bindResourceHandle(resources, NewCustomEventSpecificationWithThresholdRuleResourceHandle())
-	bindResourceHandle(resources, NewCustomEventSpecificationWithEntityVerificationRuleResourceHandle())
 	bindResourceHandle(resources, NewAlertingChannelResourceHandle())
 	bindResourceHandle(resources, NewAlertingConfigResourceHandle())
 	bindResourceHandle(resources, NewSliConfigResourceHandle())

instana/provider_test.go

@@ -5,7 +5,6 @@ import (
 
 	. "github.com/gessnerfl/terraform-provider-instana/instana"
 	"github.com/gessnerfl/terraform-provider-instana/testutils"
-	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -30,7 +29,7 @@ func TestProviderShouldContainValidSchemaDefinition(t *testing.T) {
 func TestProviderShouldContainValidResourceDefinitions(t *testing.T) {
 	config := Provider()
 
-	assert.Equal(t, 16, len(config.ResourcesMap))
+	assert.Equal(t, 13, len(config.ResourcesMap))
 
 	assert.NotNil(t, config.ResourcesMap[ResourceInstanaAPIToken])
 	assert.NotNil(t, config.ResourcesMap[ResourceInstanaApplicationConfig])
@@ -45,14 +44,6 @@ func TestProviderShouldContainValidResourceDefinitions(t *testing.T) {
 	assert.NotNil(t, config.ResourcesMap[ResourceInstanaCustomEventSpecification])
 	assert.NotNil(t, config.ResourcesMap[ResourceInstanaAlertingChannel])
 	assert.NotNil(t, config.ResourcesMap[ResourceInstanaAlertingConfig])
-
-	validateResourcesMapForCustomEvents(config.ResourcesMap, t)
-}
-
-func validateResourcesMapForCustomEvents(resourceMap map[string]*schema.Resource, t *testing.T) {
-	assert.NotNil(t, resourceMap[ResourceInstanaCustomEventSpecificationSystemRule])
-	assert.NotNil(t, resourceMap[ResourceInstanaCustomEventSpecificationThresholdRule])
-	assert.NotNil(t, resourceMap[ResourceInstanaCustomEventSpecificationEntityVerificationRule])
 }
 
 func TestProviderShouldContainValidDataSourceDefinitions(t *testing.T) {