Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for read page with props #19

Merged
merged 2 commits into from
Jan 27, 2019

Conversation

DFelten
Copy link
Contributor

@DFelten DFelten commented Jan 26, 2019

This pull request adds a possibility to get page data based on specific parameters. With the help of this new function, the desired data can be put together individually. The current existing read() function sends only limited data.

For example with readWithProps('page name', 'user|userid') you can get the user data of the last revision.

I'm using this new function, maybe someone else needs it.

@Fannon
Copy link
Contributor

Fannon commented Jan 27, 2019

Hello @DFelten !

thanks for contributing! This looks good to me. @gesinn-it Have you made the new release yet?

@gesinn-it-gea
Copy link
Collaborator

@Fannon : no, the new release is not yet done...

@gesinn-it-gea gesinn-it-gea added this to the 1.1.0 milestone Jan 27, 2019
@gesinn-it-gea
Copy link
Collaborator

@DFelten can you please add the new method also to the README.md?

@DFelten
Copy link
Contributor Author

DFelten commented Jan 27, 2019

I'm glad you liked the changes.

@gesinn-it I've added the changes to the readme.

@gesinn-it-gea gesinn-it-gea merged commit bf08e73 into gesinn-it-pub:master Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants