Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mwbot uses global cookie jar, preventing multiple-login #9

Open
ebernhardson opened this issue Nov 13, 2017 · 0 comments
Open

mwbot uses global cookie jar, preventing multiple-login #9

ebernhardson opened this issue Nov 13, 2017 · 0 comments
Labels
enhancement

Comments

@ebernhardson
Copy link

mwbot's usage of the request library does not create a cookie-jar per MWBot instance. This means that the library re-uses a global cookie jar. Due to this attempting to login multiple times in parallel with separate MWBot instances fails as the session cookies get overwritten by eachother.
siddharthvp added a commit to siddharthvp/mwn that referenced this issue May 2, 2020
@siddharthvp
Migrate from request to axios as the former is deprecated
f9dac3c 
Along the way, also fixes issue reported for MWBot gesinn-it-pub/mwbot#9 which prevent multiple bot instances to login to different accounts, and also seems like a security issue (if two bot instances are used for different wikis, the server of one wiki gets the login credentials used to login to the other wiki.)

In addition, the broken image upload functions are removed. See gesinn-it-pub/mwbot#31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ebernhardson @gesinn-it-gea