Clarify how to use edit tokens #29
Comments
siddharthvp
added a commit
to siddharthvp/mwn
that referenced
this issue
Apr 8, 2020
Fetch a new edit token on badtoken errors and retry. getEditToken() is modified to always fetch a new token, rather than abort if the token is already set. Also, make getEditToken() return the token itself (wrapped in a promise) rather than this.state (which doesn't make sense). Addresses the mwbot issue gesinn-it-pub/mwbot#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This library’s handling of edit tokens is currently a bit inconsistent, I think:
create,edit,moveetc.) read the token fromthis.editToken, and that member is also used once in the README. It’s not mentioned in API.md, though.this.state, asthis.state.csrftoken.getEditToken()returns aPromisethat resolves withthis.state, not the edit token directly. This is not documented in API.md, though.I have no idea which of these should be used when making a request directly with
request().this.editTokenlooks good, but it’s unclear if it’s part of the stable interface.getEditToken()is part of the stable interface, but resolves with an undocumented value that looks more like an implementation detail thanthis.editToken. Can you clarify this?The text was updated successfully, but these errors were encountered: