Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parser. #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix parser. #2

wants to merge 3 commits into from

Conversation

chbarts
Copy link

@chbarts chbarts commented Jul 18, 2015

This should make the parser work with the XML files YouTube is using now.

@germanger
Copy link
Owner

Hello @chbarts
Was there a breaking change in the annotations XML that Youtube returns?
Is there a post from Youtube confirming this?

@germanger
Copy link
Owner

@chbarts, I've just tried with this video annotations:
https://www.youtube.com/annotations_invideo?video_id=XpLg3saa9Ys
And it worked fine.

Can you please show me a video with the supposedly new format?
Does your pull work with the above annotations?

@chbarts
Copy link
Author

chbarts commented Jul 20, 2015

I can verify the current master on your branch fails if I download the annotations to this video with youtube-dl:

https://www.youtube.com/watch?v=Sn7Z6b9KxdE

Error message:

Unhandled Exception:
System.NullReferenceException: Object reference not set to an instance of an object
  at ConvertYoutubeAnnotationsToSRT.Program.Main (System.String[] args) [0x00000] in <filename unknown>:0 
[ERROR] FATAL UNHANDLED EXCEPTION: System.NullReferenceException: Object reference not set to an instance of an object
  at ConvertYoutubeAnnotationsToSRT.Program.Main (System.String[] args) [0x00000] in <filename unknown>:0 

Maybe it's a problem with youtube-dl? I will email you the .annotations.xml file if you want.

Anyway, the code in my pull request fixes the bug I see and produces a .srt file that VLC is happy with, so I'm satisfied with my changes. I honestly don't understand how the code in your branch could work for you.

@chbarts
Copy link
Author

chbarts commented Jul 20, 2015

Oh, sorry: Yes, my branch's code works with the annotation in the link your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants