Adding the Sparkfun WeatherKit #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Sparkfun WeatherKit as a weather station option. Product listing and data sheets are available here:
https://www.sparkfun.com/products/15901
Some things to note on this PR:
I updated the tooling and instructions in the /src/web directory to make it easier for people to update the web content. I ran into issues on MacOS when updating the web content to include a new choice of anemometer. As part of this I included the source for the filetoarray tool. I added some lines to the platformio.ini file to exclude this file from compilation so that it does not cause problems. It may be a better to place this file in a separate 'tools' directory, or not bother including it altogether if there is concern about changing the platformio.ini file.
The Sparkfun WeatherKit depends on 12 bit ADC resolution. The device uses an ADC voltage reading to compare against a pre-defined table of values to determine the direction that the weather vane is pointing. I commented out a line in the setup() function in main.cpp where analogReadResolution is being set to 10. As far as I can tell this should be safe. No other devices appear to depend on specific ADC readings to function, but this detail should be confirmed.