Implement XPowersLib for AXP management #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
already implemented in v5.3.5 |
|
Can you test with v5.3.5 ? |
|
Hello, I had a bit of time before work this morning and I did a quick build, upload and monitor.
It looks good so far. I will do more test when I have more time, but at the moment, with my TBeam v1.2 and AXP2101 it looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#137 Pull request to address the fact that AXP2101 is not supported at the moment.
Happy to have all your inputs since this is my first issue/pull request.
Please do not merge, I'm sure it can be improved a lot more.
At the moment, this is running fine on my TBeam-AXP2101-V1.2, but I didn't test on any other board, since I only have this one and I am new to this project.