Fix codec spec for 2.12 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbreslow
reviewed
Apr 26, 2019
moradology
force-pushed
the
fix/2.12-tests
branch
2 times, most recently
from
5edadf3 to
8412b80
Compare
rbreslow
approved these changes
Apr 30, 2019
|
No way, thanks to you and hector for the ops assistance |
moradology
force-pushed
the
fix/2.12-tests
branch
from
8412b80 to
3919fd4
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codec tests were failing in CI. It looks as though the 2.11 -> 2.12 bump included some changes regarding implicit resolution (? this is a bit unclear but does salve for the phenomena). With this PR we should be able to run 2.12 CI as well as 2.11