Mask on LazyMultibandRasters directly #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jisantuc
force-pushed
the
feature/js/n-ary-mb-tile-masking
branch
from
99bfe66 to
e6d7593
Compare
moradology
approved these changes
Apr 10, 2019
jisantuc
added a commit
to jisantuc/maml
that referenced
this pull request
Apr 11, 2019
pomadchin
pushed a commit
that referenced
this pull request
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR moves masking into methods on
LazyMultiBandRasterand defers the masking implementation in themaskingdirective to the underlyingLazyMultibandRaster. It supersedes #80, which only solved the problem for three specific counts of bands.Testing
Works in Raster Foundry for single band, multiband, and analyses:
Also, new tests in CI for this behavior should pass
Closes #88