Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update User Guide - Unadvertised resources #9976

Merged
merged 10 commits into from
Mar 13, 2024
Merged

Update User Guide - Unadvertised resources #9976

merged 10 commits into from
Mar 13, 2024

Conversation

ElenaGallo
Copy link
Contributor

@ElenaGallo ElenaGallo commented Feb 15, 2024 •
edited
Loading

Description

Add Unadvertised option on Resources properties section

@ElenaGallo ElenaGallo added this to the 2024.01.00 milestone Feb 15, 2024
@ElenaGallo ElenaGallo requested a review from tdipisa February 15, 2024 15:20
@ElenaGallo ElenaGallo self-assigned this Feb 15, 2024
@ElenaGallo ElenaGallo linked an issue Feb 15, 2024 that may be closed by this pull request
User Guide - Unadvertised resources and Show creator/editor #9975
Closed
2 tasks
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 5, 2024
tdipisa
tdipisa requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@tdipisa tdipisa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good. Only a few corrections in form of suggestions that you can directly apply from github UI @ElenaGallo.

docs/user-guide/resources-properties.md Outdated Show resolved Hide resolved
docs/user-guide/resources-properties.md Outdated Show resolved Hide resolved
docs/user-guide/resources-properties.md Outdated Show resolved Hide resolved
docs/user-guide/resources-properties.md Outdated Show resolved Hide resolved
docs/user-guide/resources-properties.md Outdated Show resolved Hide resolved
docs/user-guide/resources-properties.md Outdated Show resolved Hide resolved
docs/user-guide/resources-properties.md Outdated Show resolved Hide resolved
@ElenaGallo ElenaGallo requested a review from tdipisa March 12, 2024 10:50
tdipisa
tdipisa requested changes Mar 12, 2024
View reviewed changes
docs/user-guide/resources-properties.md Outdated Show resolved Hide resolved
docs/user-guide/resources-properties.md Outdated Show resolved Hide resolved
docs/user-guide/resources-properties.md Outdated Show resolved Hide resolved
@tdipisa
Copy link
Member

tdipisa commented Mar 12, 2024

There is also a failing check on ESLINT

image

Please check and fix. Thank you @ElenaGallo

@offtherailz
Copy link
Member

For some reason no-alt-text rule applies also on html images.
Probabily somewhere this fix has been applied DavidAnson/markdownlint#992 to npm (even if I see that this version is 2 years old).

I can suggest to try editing the file .markdownlint.json adding the row

"no-alt-text": false

to fix the issue temporary.
The alternative is to add an alt text to every img in the doc, but this can be postponed or done in a diffrerent PR.

@offtherailz
Copy link
Member

offtherailz commented Mar 12, 2024 •
edited
Loading

@ElenaGallo could you please re-add the rule and fix the indentation of the line, instead of removing the rule.

docs/user-guide/resources-properties.md is only the matter of an indentation, in this case is an easy fix.

offtherailz
offtherailz reviewed Mar 12, 2024
View reviewed changes
.markdownlint.json Outdated Show resolved Hide resolved
@ElenaGallo ElenaGallo requested a review from tdipisa March 13, 2024 08:31
@tdipisa
Copy link
Member

tdipisa commented Mar 13, 2024

@ElenaGallo please backport to 2024.01.xx. Thank you.

@tdipisa tdipisa merged commit 230a9e9 into geosolutions-it:master Mar 13, 2024
6 checks passed
ElenaGallo added a commit to ElenaGallo/MapStore2 that referenced this pull request Mar 14, 2024
@ElenaGallo @tdipisa @offtherailz
Update User Guide - Unadvertised resources (geosolutions-it#9976)
b709c60 
* add_9975

* add2_9975

* review_9975

* Update docs/user-guide/resources-properties.md

Co-authored-by: Tobia Di Pisa <[email protected]>

* Update docs/user-guide/resources-properties.md

Co-authored-by: Tobia Di Pisa <[email protected]>

* Update docs/user-guide/resources-properties.md

Co-authored-by: Tobia Di Pisa <[email protected]>

* delet_modify_files

* update_markdownline

* Apply suggestions from code review

---------

Co-authored-by: Tobia Di Pisa <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 14, 2024
tdipisa added a commit that referenced this pull request Mar 18, 2024
@ElenaGallo @tdipisa @offtherailz
Update User Guide - Unadvertised resources (#9976) (#10067)
0a8ecf1 
* add_9975

* add2_9975

* review_9975

* Update docs/user-guide/resources-properties.md



* Update docs/user-guide/resources-properties.md



* Update docs/user-guide/resources-properties.md



* delet_modify_files

* update_markdownline

* Apply suggestions from code review

---------

Co-authored-by: Tobia Di Pisa <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
offtherailz added a commit to offtherailz/MapStore2 that referenced this pull request Apr 10, 2024
@ElenaGallo @tdipisa @offtherailz
Update User Guide - Unadvertised resources (geosolutions-it#9976)
3419399 
* add_9975

* add2_9975

* review_9975

* Update docs/user-guide/resources-properties.md

Co-authored-by: Tobia Di Pisa <[email protected]>

* Update docs/user-guide/resources-properties.md

Co-authored-by: Tobia Di Pisa <[email protected]>

* Update docs/user-guide/resources-properties.md

Co-authored-by: Tobia Di Pisa <[email protected]>

* delet_modify_files

* update_markdownline

* Apply suggestions from code review

---------

Co-authored-by: Tobia Di Pisa <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offtherailz offtherailz offtherailz left review comments

@tdipisa tdipisa tdipisa approved these changes

Assignees

@ElenaGallo ElenaGallo

Labels
C040-COMUNE_GE-2023-CUSTOM-SUPPORT Documentation User Guide
Projects
None yet
Milestone
2024.01.00
Development

Successfully merging this pull request may close these issues.

User Guide - Unadvertised resources and Show creator/editor
3 participants
@ElenaGallo @tdipisa @offtherailz