Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9889: Fix - Unable to export map configuration in context manager #9896

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Jan 18, 2024

Description

This PR addresses the same control key causing issues when exporting context and map in the context viewer. Also, updated the viewer plugin to avoid multiple mounting of export & import context plugin

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

What is the new behavior?

  • The map export tool can be used properly inside the context viewer page
  • Avoids multiple mounting of export/import plugin in viewer page

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsuren1 good job, functionality wise it works!

can you maybe review some inline comments and give you feedback there?

web/client/plugins/ContextExport.jsx Outdated Show resolved Hide resolved
@dsuren1 dsuren1 requested a review from MV88 January 18, 2024 12:37
@MV88 MV88 merged commit b3ffd90 into geosolutions-it:master Jan 18, 2024
6 checks passed
@MV88
Copy link
Contributor

MV88 commented Jan 18, 2024

@ElenaGallo please test in DEV

@ElenaGallo
Copy link
Contributor

Test passed, @dsuren1 please backport to 2023.02.xx. Thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Jan 19, 2024
…text manager (geosolutions-it#9896)

* geosolutions-it#9889: Fix - Unable to export map configuration in context manager

* Control added to constant

(cherry picked from commit b3ffd90)
tdipisa pushed a commit that referenced this pull request Jan 19, 2024
…9896) (#9898)

* #9889: Fix - Unable to export map configuration in context manager

* Control added to constant

(cherry picked from commit b3ffd90)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment