-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9889: Fix - Unable to export map configuration in context manager #9896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsuren1
added
bug
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
AppContext
C169-Rennes-Métropole-2023-GeOrchestra4
labels
Jan 18, 2024
This was
linked to
issues
Jan 18, 2024
MV88
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsuren1 good job, functionality wise it works!
can you maybe review some inline comments and give you feedback there?
MV88
approved these changes
Jan 18, 2024
@ElenaGallo please test in DEV |
Test passed, @dsuren1 please backport to 2023.02.xx. Thanks |
dsuren1
added a commit
to dsuren1/MapStore2
that referenced
this pull request
Jan 19, 2024
…text manager (geosolutions-it#9896) * geosolutions-it#9889: Fix - Unable to export map configuration in context manager * Control added to constant (cherry picked from commit b3ffd90)
tdipisa
pushed a commit
that referenced
this pull request
Jan 19, 2024
tdipisa
removed
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the same control key causing issues when exporting context and map in the context viewer. Also, updated the viewer plugin to avoid multiple mounting of export & import context plugin
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information