Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue #9627 and associated PR comments #9680

Conversation

mumairr
Copy link
Contributor

@mumairr mumairr commented Nov 2, 2023

Description

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
Fix #9627

What is the new behavior?
Draftjs added, allows embedding of links, fonts and image upload can be handled via props

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Previous pull request at #9673 was mistakenly closed. It is linked here for reference of comments, which have been cross checked to work for branch 2022.02.xx

@mumairr mumairr added enhancement Dashboard Tasks related to dashboard Widgets labels Nov 2, 2023
@mumairr mumairr added this to the 2024.01.00 milestone Nov 2, 2023
@mumairr mumairr self-assigned this Nov 2, 2023
@mumairr mumairr requested a review from allyoucanmap November 2, 2023 19:32
@allyoucanmap allyoucanmap merged commit 6341fbd into geosolutions-it:master Nov 6, 2023
4 checks passed
@allyoucanmap
Copy link
Contributor

please @ElenaGallo test this fix on dev and let us know when we can backport to branch 2022.02.xx for geonode-mapstore-client

@allyoucanmap allyoucanmap added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 6, 2023
@ElenaGallo
Copy link
Contributor

ElenaGallo commented Nov 7, 2023

Hi @mumairr, some notes after my tests:

1_ In the widget preview, hover over a Link a link image is too big

hyperlink.mp4

2_ In the widget preview, the scroll down bar is missing

hyperlink_2.mp4

3_ The dimensions of the Embedded link change from preview to widget (Is that correct, @tdipisa?)
suize

@mumairr
Copy link
Contributor Author

mumairr commented Nov 9, 2023

Hi @mumairr, some notes after my tests:

1_ In the widget preview, hover over a Link a link image is too big

hyperlink.mp4
2_ In the widget preview, the scroll down bar is missing

hyperlink_2.mp4
3_ The dimensions of the Embedded link change from preview to widget (Is that correct, @tdipisa?) suize

Hi @ElenaGallo,

  1. Fixed, happened due to css properties applied to each img element inside editor if no image is found in link.
  2. Unable to replicate the scrollbar error, i added huge text, embedded link and an error image. Let me know if there are specific steps to reproduce it

Animation

@ElenaGallo
Copy link
Contributor

  1. Unable to replicate the scrollbar error, i added huge text, embedded link and an error image. Let me know if there are specific steps to reproduce it

@mumairr it only happens for the widget created from a map

@mumairr
Copy link
Contributor Author

mumairr commented Nov 10, 2023

  1. Unable to replicate the scrollbar error, i added huge text, embedded link and an error image. Let me know if there are specific steps to reproduce it

@mumairr it only happens for the widget created from a map

Alright, fixed up

@ElenaGallo
Copy link
Contributor

Test passed, @mumairr please backport to branch 2022.02.xx for geonode-mapstore-client. Thanks

@allyoucanmap allyoucanmap removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Quill editor with Draftjs editor in Dashboard's Text widget
4 participants