Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9552: keep the legend state for the saved maps #9619

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

mahmoudadel54
Copy link
Contributor

Description

If user saves a map with expanded/collapsed legend into TOC, the state of this legend will be saved once user saves the map.
So every time user opens the map, user will see the legend state as it is.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#9552

What is the current behavior?
#9552

What is the new behavior?
If user saves a map with expanded/collapsed legend into TOC, the state of this legend will be saved once user saves this map.
User will see the legend state kept when he opens the map later.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

@mahmoudadel54 mahmoudadel54 added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C040-COMUNE_GE-2023-CUSTOM-SUPPORT labels Oct 18, 2023
@mahmoudadel54 mahmoudadel54 added this to the 2023.02.01 milestone Oct 18, 2023
@mahmoudadel54 mahmoudadel54 requested a review from MV88 October 18, 2023 07:39
@mahmoudadel54 mahmoudadel54 self-assigned this Oct 18, 2023
@mahmoudadel54 mahmoudadel54 linked an issue Oct 18, 2023 that may be closed by this pull request
6 tasks
@MV88 MV88 merged commit 585b127 into geosolutions-it:master Oct 19, 2023
@MV88
Copy link
Contributor

MV88 commented Oct 19, 2023

@ElenaGallo please test it in DEV

@tdipisa
Copy link
Member

tdipisa commented Oct 20, 2023

@ElenaGallo let us know for the backport

@ElenaGallo
Copy link
Contributor

Test passed @mahmoudadel54 please backport to 2023.02.xx. Thanks

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request Oct 20, 2023
MV88 pushed a commit that referenced this pull request Oct 23, 2023
* #9552: keep the legend state for the saved maps

* #9552: add test cases
@MV88 MV88 removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep the legend state when saving a map
4 participants