-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9601 style issue on points generated from geo process intersection #9602
Conversation
The result looks good, anyway I was not able to test the style of polygons and lines is preserved because of the various crashes caused by the other issues. So I think to review this is better to wait the other issues to be fixed and merged from master on this branch, so we can test it in general. |
I don't understand this, I'm sorry. Using the same spearfish datasets you should be able to verify also other cases (already tested previously) without necessarily wait for #9621 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MV88 the above are regressions. |
The code looks good to me, we can bring it to the test. |
…cess intersection
bbc4d53
to
23ecca3
Compare
…cess intersection (geosolutions-it#9602)
@MV88 When When the Visual Editor Style of an intersected layer is opened, a mark, a polygon and a line rules are always displayed but:
style_1.mp4
style_2.mp4 |
The rules have a filter in there so they are applied whether the condition is satisfied. i don't see any problem in this.
probably we just have to fix the color of the line rule |
I opened this for the second point |
Description
adding line and mark style
this is the result of intersecting a polygon to a point layer
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
fix #9601
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information