Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9601 style issue on points generated from geo process intersection #9602

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Oct 16, 2023

Description

adding line and mark style

this is the result of intersecting a polygon to a point layer
image

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

fix #9601

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 added this to the 2023.02.01 milestone Oct 16, 2023
@MV88 MV88 self-assigned this Oct 16, 2023
@MV88 MV88 added the bug label Oct 16, 2023
@tdipisa tdipisa requested a review from offtherailz October 16, 2023 15:13
@offtherailz
Copy link
Member

Here the result
image

The result looks good, anyway I was not able to test the style of polygons and lines is preserved because of the various crashes caused by the other issues. So I think to review this is better to wait the other issues to be fixed and merged from master on this branch, so we can test it in general.

@tdipisa
Copy link
Member

tdipisa commented Oct 18, 2023

The result looks good, anyway I was not able to test the style of polygons and lines is preserved because of the various crashes caused by the other issues. So I think to review this is better to wait the other issues to be fixed and merged from master on this branch, so we can test it in general.

I don't understand this, I'm sorry. Using the same spearfish datasets you should be able to verify also other cases (already tested previously) without necessarily wait for #9621

Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I try to intersect polygon with Polygon or Polygon to lines, I see a point in the middle.

image

image

@tdipisa
Copy link
Member

tdipisa commented Oct 18, 2023

@MV88 the above are regressions.

@MV88 MV88 requested a review from offtherailz October 18, 2023 16:20
@offtherailz
Copy link
Member

The code looks good to me, we can bring it to the test.

@offtherailz offtherailz enabled auto-merge (squash) October 19, 2023 08:18
@MV88 MV88 force-pushed the 9601_point_style branch from bbc4d53 to 23ecca3 Compare October 19, 2023 10:52
@offtherailz offtherailz merged commit fbe7d0b into geosolutions-it:master Oct 19, 2023
4 checks passed
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 19, 2023
MV88 added a commit to MV88/MapStore2 that referenced this pull request Oct 19, 2023
@ElenaGallo
Copy link
Contributor

@MV88 When When the Visual Editor Style of an intersected layer is opened, a mark, a polygon and a line rules are always displayed but:

  • if the layer is a point there should only be the mark rule or if the layer is a polygon there should only be the polygon rule
style_1.mp4
  • if the layer is a line there should only be the rule line, with a visible color
style_2.mp4

@MV88
Copy link
Contributor Author

MV88 commented Oct 19, 2023

When When the Visual Editor Style of an intersected layer is opened, a mark, a polygon and a line rules are always displayed

The rules have a filter in there so they are applied whether the condition is satisfied. i don't see any problem in this.

if the layer is a line there should only be the rule line, with a visible color

probably we just have to fix the color of the line rule

@MV88
Copy link
Contributor Author

MV88 commented Oct 19, 2023

When When the Visual Editor Style of an intersected layer is opened, a mark, a polygon and a line rules are always displayed

The rules have a filter in there so they are applied whether the condition is satisfied. i don't see any problem in this.

if the layer is a line there should only be the rule line, with a visible color

probably we just have to fix the color of the line rule

I opened this for the second point
#9632

@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoProcessing - it does not includes points style that can result from intersection of polygon and point
4 participants