Fix #9147 Issue in chart creation from feature grid. #9214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allyoucanmap
added
bug
BackportNeeded
1 task
1 task
MV88
requested changes
Jun 9, 2023
There was a problem hiding this comment.
when you apply a spatial filter like a rectangle to the attribute table
then you go and create a chart then you want to additionally filter,
the previous spatial filter is present in the UI only and not drawn in the map
if this requires a new issue, please open it, and then i think we can merge this
MV88
approved these changes
Jun 9, 2023
|
@ElenaGallo please test this on dev and let me know when I can backport to 2023.01.xx, thanks |
1 task
|
Test passed, @allyoucanmap please backport to the stable branch. Thanks |
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this pull request
Jun 9, 2023
tdipisa
removed
the
BackportNeeded
tdipisa
pushed a commit
that referenced
this pull request
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the initialization of charts from the feature grid. The feature grids widget button was not creating an array of charts.
This PR should solve also #9202
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#9147
#9202
What is the new behavior?
Restored the creation of chart widgets from the feature grid
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information