[Backport 2023.01.xx] Fix #9189 3d height from terrain not working with cesium terrain provider (#9191) #9192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…um terrain provider (geosolutions-it#9191)
allyoucanmap
added
bug
Backport
3D
tdipisa
approved these changes
May 25, 2023
|
@ElenaGallo backport just merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a problem due to the missing .catch method in the default terrain provider.
Cesium.sampleTerrainMostDetailedis using a promise implemented with thewhen.jslibrary that does not exposes the catch method. There was a similar issue with the leader line style that is using the same methodPlease check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#9189
What is the new behavior?
It is possible to use the measure height from terrain and leader line style also with cesium terrain provider
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information