-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8055 allow to load 3dtiles tileset via viewer parameters #9021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the 3D switch implementation starts from 2D, then commutes to 3D when the data is available.
This unnecessary rendering is a little ugly and may be confusing.
I noticed that instead if you put the proper parameters (used for 3D share for coordinates of the camera) this do not happen.
So I'd suggest to avoid this auto-switch to 3D option based on layer added, and ask explicitly parameters for 3D version of the map.
|
||
GET: `#/viewer/config?actions=[{"type":"CATALOG:ADD_LAYERS_FROM_CATALOGS","layers":["https://example.com/tileset-pathname/tileset.json"],"sources":[{"type":"3dtiles","url":"https://example.com/tileset-pathname/tileset.json"}]}]` | ||
|
||
- Use the `title` property in the source object to assign the name to the layer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title is an identifier for the layers in 3D tiles? if so, please explain, something like
- Use the `title` property in the source object to assign the name to the layer | |
- Because `title` is the identifier used for 3D tiles. use`title` property in the source object to assign the name to the layer |
Anyway, I should use name, and allow to use the title property for (maybe localized) items. This way it is conformant with the rest of the MapStoe model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new configuration the title property is not visible anymore
moved the switch at higher level to ensure the map switch to 3D as soon as possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one clarification comment
@offtherailz just curious, what do you have in mind ? setting |
The layer element is a string used initially as text in the filter for the .textSearch method of the catalog and then used as identifier to match the specific layer in the catalog. The 3D tiles does not need filter or search text because the record is already one so I simply used this information as default title. I don't think an object is really needed for the moment |
The idea is to try to see if we can respect as much as possible the same schema and functionalities of the WMS layers so we can expect more or less the same interface and functionalities. What we implemented now works well and satisfies the requirements we have, I just asked to @allyoucanmap to check this point. |
…m 3d tiles service
@offtherailz just improved a bit the parsing of the title and added the related doc, see |
Co-authored-by: Lorenzo Natali <[email protected]>
@ElenaGallo please test on dev and let me know if I can backport on branch 2023.01.xx, thanks |
@allyoucanmap the rest passed on DEV, @landryb please backport to 2023.01.xx. Thanks |
i'm not sure i should be the one backporting, same for #9048, but can do if needed :) |
@landryb don't worry, I'll do the backport of this |
…ters (geosolutions-it#9021) Co-authored-by: Lorenzo Natali <[email protected]>
… parameters (#9021) (#9060) * #8055 allow to load 3dtiles tileset via viewer parameters (#9021) Co-authored-by: Lorenzo Natali <[email protected]> * fix tests --------- Co-authored-by: Lorenzo Natali <[email protected]>
Description
This PR introduces the possibility to include a 3D Tiles layer with the query parameters. The viewer switches to 3D view it it detect a 3D tiles layer among the one included in the query parameter action
CATALOG:ADD_LAYERS_FROM_CATALOGS
Here the introduced structures:
GET:
#/viewer/config?actions=[{"type":"CATALOG:ADD_LAYERS_FROM_CATALOGS","layers":["My 3D Tiles Layer"],"sources":[{"type":"3dtiles","url":"https://example.com/tileset-pathname/tileset.json"}]}]
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#8055
What is the new behavior?
It its possible to add 3D tiles layer with the query parameter action
CATALOG:ADD_LAYERS_FROM_CATALOGS
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information