#8695 Move Identify plugin into main bundle #8708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allyoucanmap
approved these changes
Oct 18, 2022
|
@ElenaGallo please test on dev and let us know when we can backport on 2022.02.xx |
|
Test passed on DEV, @alex-fko please backport to 2022.02.xx |
ElenaGallo
added
the
BackportNeeded
alex-fko
added a commit
to alex-fko/MapStore2
that referenced
this pull request
Oct 18, 2022
…ons-it#8708) (cherry picked from commit 24f4ec7)
tdipisa
removed
the
BackportNeeded
alex-fko
added a commit
to alex-fko/MapStore2
that referenced
this pull request
Oct 18, 2022
…ons-it#8708) (cherry picked from commit 24f4ec7)
tdipisa
pushed a commit
that referenced
this pull request
Oct 18, 2022
… Fix issues for OpenID Login due to modularization; Add measure reducer into appReducers list (#8711) * #8695 Move Identify plugin into main bundle (#8708) (cherry picked from commit 24f4ec7) * Added measure reducer into appReducers list * #8487: Fix issues for OpenID Login due to modularization (#8490) (cherry picked from commit 698aeeb) Co-authored-by: Lorenzo Natali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Identifyis one of the plugins which configuration can be defined by object passed inlocalConfigininitialState.defaultState.mapInfo. Reducers of module plugins are registered once plugin should be rendered on the page for the first time. At the same time, Redux denies to use state values added prior to the reducer registration, which makes this approach of configuration definition not possible when plugin is a module.This PR adds
Identifyback to the main bundle to fix the regressionPlease check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#8695
What is the new behavior?
Plugin is static, therefore configuration applied this way works as expected.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information