-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8675 Query parameters documentation and lon,lat
order unification
#8676
8675 Query parameters documentation and lon,lat
order unification
#8676
Conversation
…on of coordinates in parameters
@@ -761,7 +761,7 @@ describe('queryparam epics', () => { | |||
}, | |||
router: { | |||
location: { | |||
search: "?featureInfo=38.72,-95.625" | |||
search: "?featureInfo=-95.625,38.72" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied this change because lat -95 doesn't exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only inverted the coordinates in the test because -95 latitude doesn't exist, not that issue anyway.
From my code inspection, this can go straight to the test.
@ElenaGallo, could you please test this on DEV ? Thank you |
Test passed on DEV, @alex-fko please backport to stable branch. Thanks |
…eosolutions-it#8676) (cherry picked from commit f4c35ca)
Description
This PR updates documentation for query parameters that specify coordinates with unnamed, comma-separated format.
It also changes order to
lng,lat
forfeatureInfo
parameter to match all other parameters.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#8675
What is the new behavior?
As per description
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information