Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8675 Query parameters documentation and lon,lat order unification #8676

Conversation

alex-fko
Copy link
Contributor

Description

This PR updates documentation for query parameters that specify coordinates with unnamed, comma-separated format.
It also changes order to lng,lat for featureInfo parameter to match all other parameters.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Documentation update

Issue

What is the current behavior?
#8675

What is the new behavior?
As per description

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@@ -761,7 +761,7 @@ describe('queryparam epics', () => {
},
router: {
location: {
search: "?featureInfo=38.72,-95.625"
search: "?featureInfo=-95.625,38.72"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied this change because lat -95 doesn't exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ;)

Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only inverted the coordinates in the test because -95 latitude doesn't exist, not that issue anyway.

From my code inspection, this can go straight to the test.

@offtherailz offtherailz merged commit f4c35ca into geosolutions-it:master Oct 10, 2022
@offtherailz offtherailz added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 10, 2022
@offtherailz
Copy link
Member

@ElenaGallo, could you please test this on DEV ? Thank you

@ElenaGallo
Copy link
Contributor

Test passed on DEV, @alex-fko please backport to stable branch. Thanks

alex-fko added a commit to alex-fko/MapStore2 that referenced this pull request Oct 11, 2022
tdipisa pushed a commit that referenced this pull request Oct 11, 2022
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants