Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8573 Fix permissions dropdowns #8590

Conversation

belom88
Copy link
Contributor

@belom88 belom88 commented Sep 19, 2022

Description

Open group permissions dropdowns to up direction
Screenshot from 2022-09-19 10-08-59

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#8573

What is the new behavior?
The dropdowns of the insert row open in up direction to assure they won't be hidden

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

I tried to change styles of parent containers to show dropdown over. It cannot be done safely because parent containers have overflow:hidden. Also even if we open this dropdown in down direction somehow, it will be shown out of the screen bounds for some screen sizes.

Open group permissions dropdowns to up direction
@belom88 belom88 self-assigned this Sep 19, 2022
@belom88 belom88 linked an issue Sep 19, 2022 that may be closed by this pull request
1 task
Copy link
Contributor

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allyoucanmap allyoucanmap added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 22, 2022
@allyoucanmap allyoucanmap changed the title geosolutions-it#8573 Fix permissions dropdowns #8573 Fix permissions dropdowns Sep 22, 2022
@allyoucanmap allyoucanmap merged commit 077e079 into geosolutions-it:master Sep 22, 2022
@tdipisa
Copy link
Member

tdipisa commented Sep 22, 2022

@ElenaGallo please test this in DEV and let us know. For the backport to 2022.02.xx we have to wait after the release of 2022.02.00 @belom88.

@ElenaGallo
Copy link
Contributor

Test passed on DEV

belom88 added a commit to belom88/MapStore2 that referenced this pull request Sep 29, 2022
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 29, 2022
tdipisa pushed a commit that referenced this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group permission dropdown not properly visible
4 participants