#8586 Make eager option configurable for extensions shared libraries #8587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allyoucanmap
approved these changes
Sep 14, 2022
tdipisa
added
the
BackportNeeded
|
@alexander-fedorenko @ElenaGallo this is scheduled for 2022.02.01 so please let's wait the delivery of 2022.02.00 before backporting this. you can start testing on DEV anyway @ElenaGallo. |
|
@tdipisa @ElenaGallo This is not possible to test via UI, this fix will allows to set a flag to improve the final bundle for the extensions. We need to build an extension using this fix to verify the improvement. |
so that's the test no? :-) |
|
@alexander-fedorenko can you please backport this to 2022.02.xx? |
alex-fko
pushed a commit
to alex-fko/MapStore2
that referenced
this pull request
Sep 29, 2022
…ared libraries (geosolutions-it#8587) (cherry picked from commit 3c31f3c)
tdipisa
removed
the
BackportNeeded
tdipisa
pushed a commit
that referenced
this pull request
Sep 29, 2022
…8587) (#8633) (cherry picked from commit 3c31f3c) Co-authored-by: Alexander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the changes suggested in PR each extension will have a way to configure
eageroption for shared libraries.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#8586
What is the new behavior?
Eager option can be overridden by configuration passed from extension
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information