Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7934 refactor to version plugin, moving it to About plugin #8504

Merged
merged 11 commits into from
Aug 26, 2022

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Aug 22, 2022

Description

Moved Version plugin to About and removing it from very involved place
incudes also a fix on REDUCERS_LOADED action dispatched multiple times

fixed also style incase of mobile
image

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#7934

What is the new behavior?

Now version info are included as part of about plugin

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Note for testers, also creating a new project and running it should be tested

@MV88 MV88 requested a review from allyoucanmap August 22, 2022 16:25
@MV88 MV88 self-assigned this Aug 22, 2022
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Aug 22, 2022
build/tests.webpack.js Outdated Show resolved Hide resolved
createProject.js Outdated Show resolved Hide resolved
docs/developer-guide/mapstore-migration-guide.md Outdated Show resolved Hide resolved
web/client/hooks/useModulePlugins.js Outdated Show resolved Hide resolved
web/client/hooks/useModulePlugins.js Outdated Show resolved Hide resolved
web/client/hooks/useModulePlugins.js Outdated Show resolved Hide resolved
@MV88 MV88 requested a review from allyoucanmap August 25, 2022 10:09
@MV88 MV88 merged commit f361bdf into geosolutions-it:master Aug 26, 2022
@MV88
Copy link
Contributor Author

MV88 commented Aug 26, 2022

@ElenaGallo testable in DEV

MV88 added a commit to MV88/MapStore2 that referenced this pull request Aug 26, 2022
…lugin (geosolutions-it#8504)

* geosolutions-it#7934 refactor to version plugin, moving it to About plugin
* update migration guideline

# Conflicts:
#	web/client/hooks/useModulePlugins.js
#	web/client/plugins/Version.jsx
#	web/client/product/plugins.js
@MV88 MV88 removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Aug 26, 2022
MV88 added a commit that referenced this pull request Aug 26, 2022
…8510)

* #7934 refactor to version plugin, moving it to About plugin
* update migration guideline

# Conflicts:
#	web/client/hooks/useModulePlugins.js
#	web/client/plugins/Version.jsx
#	web/client/product/plugins.js
@ElenaGallo
Copy link
Contributor

Test passed, @MV88 please backport to 2022.02.xx. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants