Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6830. Disable URL update on initial scroll #6835

Merged
merged 4 commits into from
May 11, 2021

Conversation

offtherailz
Copy link
Member

Description

Work in progress. TODOS:

  • Extenalize actions
  • add Unit test

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#6830

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 this should solve the issue.

@offtherailz offtherailz requested a review from MV88 May 6, 2021 14:12
@offtherailz offtherailz self-assigned this May 6, 2021
@offtherailz offtherailz marked this pull request as ready for review May 11, 2021 13:49
@MV88 MV88 merged commit 6cc3ca2 into geosolutions-it:master May 11, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 78.744% when pulling 6042ad5 on offtherailz:6830 into ae25991 on geosolutions-it:master.

MV88 added a commit that referenced this pull request May 12, 2021
* #6830. Disable URL update on initial scroll

* add test and externalize actions (#31)

* parametrize delay (#32)

* Fixed lint

Co-authored-by: Matteo V <[email protected]>
agpenton pushed a commit to agpenton/MapStore2 that referenced this pull request Jul 8, 2021
…ons-it#6835)

* geosolutions-it#6830. Disable URL update on initial scroll

* add test and externalize actions (geosolutions-it#31)

* parametrize delay (geosolutions-it#32)

* Fixed lint

Co-authored-by: Matteo V <[email protected]>
agpenton pushed a commit to agpenton/MapStore2 that referenced this pull request Jul 8, 2021
…ons-it#6835)

* geosolutions-it#6830. Disable URL update on initial scroll

* add test and externalize actions (geosolutions-it#31)

* parametrize delay (geosolutions-it#32)

* Fixed lint

Co-authored-by: Matteo V <[email protected]>
dsuren1 pushed a commit to dsuren1/MapStore2 that referenced this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants