Maps catalog page #4994
Merged
Maps catalog page #4994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offtherailz
requested changes
Mar 9, 2020
There was a problem hiding this comment.
- Please add unit tests (changes on existing enhancers, your epics and missing react/redux stuff
- document the reducer (only one property)
- Please make this plugin available in context creation tool (with proper dependencies and localization) The icon have to be created.
| const loadMoreStream = (initialStream$, loadMore$, loadPage, {dataProp = "items", throttleTime = 500} = {}) => | ||
| initialStream$.switchMap(searchParams => | ||
| const loadMoreStream = (initialStream$, loadMore$, loadPage, {dataProp = "items", initialStreamDebounce = 0, throttleTime = 500} = {}) => | ||
| initialStream$.take(1).concat(initialStream$.debounceTime(initialStreamDebounce)).switchMap(searchParams => |
There was a problem hiding this comment.
can you explain the reason this take + concat change? Maybe a comment can help understanding it?
There was a problem hiding this comment.
It makes the first initialStream event to be executed instantly regardless of the initialStreamDebounce value. This is useful because the first event is dispatched when a dialog, a panel, etc. with infinite scroll is opened, debounce is not needed there.
|
@allyoucanmap should provide the icon for the new plugin |
|
the one on the map, please compare with dev instance and ping me as soon as is ready so it can be merged. |
offtherailz
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new plugin MapCatalog that is a list of maps available to the user. Supports delete, editing properties, sharing.
P.S. As I understand it, this plugin is for usage in georchestra, so i didn't include it in localConfig.
P.S.S. After this is merged a separate pr should be submitted to georchestra that updates MapStore and adds this plugin to list of plugins and localConfig there.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
mapstore2-georchestra/#59
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)