Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4944 Impossible to remove all plugins from the right list of wizard s… #4949

Merged
merged 2 commits into from
Mar 2, 2020
Merged

4944 Impossible to remove all plugins from the right list of wizard s… #4949

merged 2 commits into from
Mar 2, 2020

Conversation

gitcontributor
Copy link
Contributor

@gitcontributor gitcontributor commented Feb 27, 2020

…tep n2 while editing an existing contexts (it seems to happen only in geOrchestra MS project).

Description

Impossible to remove all plugins from the rigth list of wizard step n2 while editing an existing contexts (it seems to happen only in geOrchestra MS project).

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
#4944

What is the new behavior?
It is now possible to remove all plugins from the rigth list of wizard step n2 while editing an existing ncontexts (it seems to happen only in geOrchestra MS project).

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

…tep #2 while editing an existing contexts (it seems to happen only in geOrchestra MS project).
@gitcontributor gitcontributor added this to the 2020.02.00 milestone Feb 27, 2020
@gitcontributor gitcontributor self-assigned this Feb 27, 2020
@coveralls
Copy link

coveralls commented Feb 27, 2020

Coverage Status

Coverage decreased (-0.003%) to 83.843% when pulling 686ea5f on gitcontributor:4944-impossible-remove-all-plugins-contexts into 8fd79e8 on geosolutions-it:master.

@offtherailz offtherailz changed the title 4944 Impossible to remove all plugins from the rigth list of wizard s… 4944 Impossible to remove all plugins from the right list of wizard s… Feb 28, 2020
@offtherailz offtherailz self-requested a review February 28, 2020 08:36
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a unit test that prevents this use case

@offtherailz offtherailz merged commit f0a6c73 into geosolutions-it:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants