Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3930 short height of query panel filter when opened in dashboard #4105

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

kasongoyo
Copy link
Contributor

@kasongoyo kasongoyo commented Aug 23, 2019

Description

Fix the query panel height when opened in dashboard context

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
see #3930

What is the new behavior?
Screenshot 2019-08-23 at 15 07 33

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Please add a test for this fix

@tdipisa tdipisa added this to the 2019.02.01 milestone Aug 27, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.313% when pulling 128be45 on kasongoyo:feature/3930 into 7204116 on geosolutions-it:master.

appliedFilterSelector,
storedFilterSelector,
(state) => state && state.query && state.query.isLayerFilter,
selectedLayerLoadingErrorSelector
], (enabled, groups, settings, querypanelEnabled, layout, appliedFilter, storedFilter, advancedToolbar, loadingError) => ({
], (enabled, groups, settings, querypanelEnabled, layoutHeight, dashboardAvailable, appliedFilter, storedFilter, advancedToolbar, loadingError) => ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you changed the name here from layout to layoutHeight?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was misleading; the property contains only layout height.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@kasongoyo
Copy link
Contributor Author

Hi, Please add a test for this fix

Adding a test for this plugin is overkill for the changes I only did.

@MV88
Copy link
Contributor

MV88 commented Aug 29, 2019

Hi, Please add a test for this fix

Adding a test for this plugin is overkill for the changes I only did.

ok

@MV88 MV88 merged commit 65e7e63 into geosolutions-it:master Aug 29, 2019
@MV88
Copy link
Contributor

MV88 commented Aug 29, 2019

@kasongoyo please backport this to 2019.02.xx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants