Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3852 Annotation do not work without setting initial state #4076

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

kasongoyo
Copy link
Contributor

@kasongoyo kasongoyo commented Aug 8, 2019

Description

It turned out the annotation plugin cannot draw on the map when
the default configuration is not provided. This commit fix and allow
annotation to work well without default config.

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
see #3852

What is the new behavior?
see the description section above

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…al state

It turned out the annotation plugin cannot draw on the map when
the default configuration is not provided. This commit fix and allow
annotation to work well without default config.
@kasongoyo kasongoyo added this to the 2019.02.01 milestone Aug 8, 2019
@tdipisa tdipisa requested a review from offtherailz August 9, 2019 07:49
@offtherailz offtherailz merged commit e1891a1 into geosolutions-it:master Aug 9, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 82.194% when pulling 61ccb36 on kasongoyo:feature/3852 into e470657 on geosolutions-it:master.

offtherailz pushed a commit to offtherailz/MapStore2 that referenced this pull request Aug 9, 2019
@offtherailz offtherailz mentioned this pull request Aug 9, 2019
offtherailz added a commit that referenced this pull request Aug 12, 2019
 Portings for the following PRs from master b to branch 2019.02.xx:

- #3988
- #4016
- #3998
- #4003
- #3991
- #4004
- #4006
- #4008
- #4025
- #4071
- #4019
- #4076
- #4077
- #4081

Target release is o add them to 2019.02.01
@kasongoyo kasongoyo deleted the feature/3852 branch August 13, 2019 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants