Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3835: upgrade to openlayers 5.3.0 #4058

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Fixes #3835: upgrade to openlayers 5.3.0 #4058

merged 2 commits into from
Aug 30, 2019

Conversation

mbarto
Copy link
Contributor

@mbarto mbarto commented Aug 6, 2019 •
edited by tdipisa
Loading

Description

This PR introduces:

  • Upgrade to OpenLayers 5.3.0
  • Vector format for openlayers WMTS and WMS
  • Base support for WFS3 Layer in openlayers

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
MapStore uses OpenLayers 4.x

What is the new behavior?
MapStore uses OpenLayers 5.3.0

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: projects depending on OpenLayers 3/4 will need to be migrated

Other information:

@mbarto mbarto requested a review from allyoucanmap August 6, 2019 08:00
@coveralls
Copy link

coveralls commented Aug 6, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 82.336% when pulling 07f8af6 on mbarto:ol5_rebased into 65e7e63 on geosolutions-it:master.

allyoucanmap
allyoucanmap reviewed Aug 6, 2019
View reviewed changes
web/client/components/map/openlayers/__tests__/ScaleBar-test.jsx Outdated
layers: [
],
controls: ol.control.defaults({
attributionOptions: /** @type {olx.control.AttributionOptions} */ {
/*controls: ol.control.defaults({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is commented code, maybe we can remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allyoucanmap I should have removed them now

@tdipisa tdipisa added this to the 2019.03.00 milestone Aug 27, 2019
@tdipisa tdipisa merged commit 43ed67f into geosolutions-it:master Aug 30, 2019
MV88 added a commit that referenced this pull request Oct 2, 2019
@MV88
Fixes #3835: upgrade to openlayers 5.3.0 (#4058)
572887c 
# Conflicts:
#	package-lock.json
#	web/client/components/map/leaflet/__tests__/Layer-test.jsx
#	web/client/utils/DrawSupportUtils.jsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allyoucanmap allyoucanmap allyoucanmap approved these changes

Assignees

@mbarto mbarto

Labels
None yet
Projects
None yet
Milestone
2020.01.00
Development

Successfully merging this pull request may close these issues.
4 participants
@mbarto @coveralls @allyoucanmap @tdipisa