Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3713 Pop up Validation error doesn't show up for SLD (add default message) #3771

Merged
merged 1 commit into from
May 20, 2019

Conversation

allyoucanmap
Copy link
Contributor

Description

This PR add a default message in validation of Style Editor when the message doesn't contain information about the error.

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

What is the current behavior? (You can also link to an open issue here)
Some server doesn't return a parsable message of error

What is the new behavior?
add a default message in validation

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@allyoucanmap allyoucanmap added this to the 2019.01.01 milestone May 20, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 81.41% when pulling db9c97b on allyoucanmap:style-default-popup into b2eefd6 on geosolutions-it:master.

@tdipisa tdipisa requested a review from offtherailz May 20, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pop up Validation error doesn't show up for SLD
4 participants