Externalized in epic getFeatureInfo retrieval logic #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mbarto
suggested changes
Mar 13, 2019
| panelClassName: "modal-dialog info-panel modal-content", | ||
| headerClassName: "modal-header", | ||
| bodyClassName: "modal-body info-wrap", | ||
| dock: true, | ||
| headerGlyph: "", | ||
| closeGlyph: "1-close", | ||
| className: "square-button", | ||
| allowMultiselection: false, |
There was a problem hiding this comment.
I would not remove this without an explicit reason.
There was a problem hiding this comment.
I partially maintained it (that it means that is not configurable anymore, but the code base for this flag is still maintained and tested).
Ideally, after this changes, it should go in the application state.
If you want I can finalize the support for this flag in the mapInfo state.
There was a problem hiding this comment.
mbarto
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request moves the request build and trigger logic from the FeatureInfoContainer to the
identifyepic. ThisThis refactor is required to allow clicked feature highlight (#3617)
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
No changes
What is the new behavior?
Same as before. The only difference is about multiSelection (disabled by default:
multiSelectionflag is has been moved temporary from the Component configuration onto the action (is not configurable, we need a little more work to make configurable from the app state, but I didn't want to complicate things forc125_annotationsmerge too much, for a feature that is not used neither documented).Does this PR introduce a breaking change? (check one with "x", remove the other)