setting the default layer as object #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
offtherailz
requested changes
Sep 25, 2018
There was a problem hiding this comment.
- Please add a unit test for this reducer default
- Add a unit test for autoMapUpdate epic (the effective issue)
suggestion: try to replicate the issue in autoMapUpdate test using the reducer (not fixed) for initial state (See how epics are tested here and there). Then apply your fix to verify that the problem is solved. You can even fix autoMapUpdate using layersSelector wrap the state access correcly
offtherailz
approved these changes
Sep 27, 2018
offtherailz
added a commit
that referenced
this pull request
Oct 4, 2018
tdipisa
pushed a commit
that referenced
this pull request
Oct 4, 2018
* Revert "Removes console logs from browser from karma testing output (#3207)" This reverts commit 264ef58. * Revert "Fix #3209 show/hide title translations in layer settings (#3210)" This reverts commit 415e63d. * Revert "Fixes #2669: use https version of geosolutions maven repo (#3182)" This reverts commit dc4084c. * Revert "Automatic definition of proj codes from configuration in OpenLayers maps (#3133)" This reverts commit 70ee3b9. * Revert "Fix #3192 setting the default layer as object (#3199)" This reverts commit fe50170. * Revert "Fix #2298 de-DE translation fix (#3205)" This reverts commit e39348a. * Revert "hiding div to allow playing/showing the video (#3188)" This reverts commit a7c9e66.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
solving the error resulted from the new update of chrome and firefox
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
see #3192
What is the new behavior?
when the user access a an authorized map. the login prompt pops up and an error loading map massage is rendered in the middle of the screen.
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
The default value of layer was replaced into an object. No unit-test was added since in all the pre-existing tests the layers value is already an object.