Added details to Map #2495
Closed
Added details to Map #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # web/client/epics/__tests__/featuregrid-test.js # web/client/plugins/Maps.jsx
ghost
added
offtherailz
requested changes
Dec 19, 2017
web/client/actions/maps.js
Outdated
| /** | ||
| * open details | ||
| * @memberof actions.maps | ||
| * @return {action} type `OPEN_AND_FETCH_DETAILS` |
| } | ||
| }, | ||
| glyph: "chevron-up", | ||
| tooltip: LocaleUtils.getMessageById(this.context.messages, "map.details.show") |
| this.stopPropagate(evt); | ||
| this.onEdit(this.props.map, false); | ||
| if (!this.props.map.detailsText) { | ||
| this.props.detailsSheetActions.onOpenOrFetchDetails({open: true, fetch: true, readOnly: true}); |
There was a problem hiding this comment.
trigger fetch (if details are not present) with an epic removing it from UI part.
UI should only show the detail text or loading if present but not loaded yet. Pay attention to empty strings
offtherailz
requested changes
Dec 21, 2017
There was a problem hiding this comment.
- When you open a map without details, you have the following error.
{data: "Resource attribute not found", status: 404, statusText: "Not Found", headers: {…}, config: {…}, …}
- About this map does not open anything.
- save desn't seems to work if you insert a big image in details. No notification about any error. Clicking on save do not show any result and does not allow to close the map editing window.
| const name = this.generateUUID(); // create new unique name | ||
| const category = "THUMBNAIL"; | ||
| // user removed the thumbnail (the original url is present but not the preview) | ||
| if (this.props.map && !data && this.props.map.thumbnail && !this.refs.imgThumbnail && !metadata) { |
There was a problem hiding this comment.
this logic is messy. You should identify the correct condition and variables to pass to saveAll, delete old thumbnail.
Ideally you should call them once per function
5 tasks
|
Wating for #2505 to be merged before update this |
|
This conflicts, please resolve conflicts |
|
if you see my comment i'm waiting another PR to be merged before i do any fix on this. |
|
Please solve conflicts, we can move on, #2505 is merged |
|
closing this, solving conflicts here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added details in viewer page (under burger menu) if they are present for the opened map.
Added details section in map card
various actions available for details:
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
Actually is not possible to add details to the map and therefore to change/delete them
What is the new behavior?
it is possible from the homepage map card.
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information:
You need to add DETAILS category to the configured geostore