Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2491. Avoid wrong coordinate changes with openlayers map click #2492

Merged
merged 1 commit into from
Dec 18, 2017

Conversation

offtherailz
Copy link
Member

Description

The openlayers map simulate feature click inside his singleclick event. The problem was that the point was moved everytime a vector layer is clicked, not only when the layer had handleClickOnLayer set to true.
For the future (and all the maps) I think we should avoid this and pass in the click event the feature clicked, instead of changing the clicked point. This is easier now because the mouse click event is now managed separately from the feature info.

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?
See #2491

What is the new behavior?
The marker is in the correct point.
The behavior is the original when handleClickOnLayer is true.
image

Does this PR introduce a breaking change?

  • No

@ghost ghost assigned offtherailz Dec 15, 2017
@ghost ghost added In Test labels Dec 15, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 80.748% when pulling 8252235 on offtherailz:i2491 into d8d5b60 on geosolutions-it:master.

@offtherailz offtherailz requested a review from mbarto December 15, 2017 17:18
@offtherailz offtherailz merged commit a6d1057 into geosolutions-it:master Dec 18, 2017
@ghost ghost added the Accepted label Dec 18, 2017
@offtherailz offtherailz deleted the i2491 branch February 18, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openlayers moves marker when click on vector data
4 participants