Add ui to configure text search services #1841

kappu72 · 2017-05-18T10:06:15Z

This plugins adds a ui to configure text search services. With this pool configured services will be saved and loaded from map config.
To use, add
SearchServicesConfigPlugin: require('../plugins/SearchServicesConfig' to plugins.config and configure in localConfig.json

coveralls · 2017-05-18T10:15:33Z

Coverage decreased (-0.08%) to 79.479% when pulling 7425b0d on kappu72:master into 2a9f77a on geosolutions-it:master.

offtherailz · 2017-05-18T10:39:43Z

web/client/components/mapcontrols/searchservicesconfig/SearchServices.css

+  transition: left 0.3s, top 0.3s;
+}
+.noUi-state-drag * {
+  cursor: inherit !important;


don't use !important

offtherailz · 2017-05-18T10:40:38Z

web/client/components/mapcontrols/searchservicesconfig/SearchServices.css

@@ -0,0 +1,403 @@
+/* all this css rules are related to the slider, copy paste from advanced layertree example */
+
+.noUi-target,


these are generic for every noUi, please make them more specific or move the generic css in proper folders

offtherailz · 2017-05-18T10:42:49Z

web/client/plugins/SearchServicesConfig.jsx

@@ -0,0 +1,211 @@
+/**


Avoid /** in favor of /* to allow documentation

offtherailz · 2017-05-18T10:44:16Z

web/client/plugins/SearchServicesConfig.jsx

+const WFSOptionalProps = require('../components/mapcontrols/searchservicesconfig/WFSOptionalProps.jsx');
+
+
+const SearchServicesConfigPanel = React.createClass({


Document the plugin. see http://dev.mapstore2.geo-solutions.it/mapstore/docs/building-and-developing

offtherailz · 2017-05-18T10:48:20Z

web/client/translations/data.it-IT

@@ -266,7 +266,31 @@
            "bearingLabel": "Direzione"
        },
        "search":{
-            "placeholder": "Cerca un indirizzo o inserisci coordinate..."
+            "placeholder": "Cerca un indirizzo o inserisci coordinate...",


for french and german use an online service.

offtherailz · 2017-05-18T10:49:39Z

web/client/translations/data.en-US

+            "savebtn": "Update",
+            "cancelbtn": "Cancel",
+            "confirmremove": "Delete?",
+            "cancelconfirm": "Confirm Cancel?",


Do you confirm? or are you sure?

offtherailz · 2017-05-18T10:50:02Z

web/client/translations/data.it-IT

+            "addbtn": "Aggiungi",
+            "cancelbtn": "Annulla",
+            "confirmremove": "Elimina?",
+            "cancelconfirm": "Confermi annulla?",


Confermi? or "Sei sicuro?"

offtherailz · 2017-05-18T10:50:31Z

web/client/translations/data.en-US

+            "searchservicesbutton": "Configure search services",
+            "configpaneltitle": "Create/edit a search service",
+            "serviceslistlabel": "Available services",
+            "overriedservice": "Overried services",


Override default services

offtherailz · 2017-05-18T10:53:09Z

web/client/translations/data.it-IT

+            "s_wfs_props_label" : "Proprietà WFS service",
+            "s_wfs_opt_props_label" : "Proprietà facoltative",
+            "s_result_props_label": "Proprietà di visualizzazione dei risultati",
+            "s_priority_info": "Usato per oridnare resultati, valori più alti per primi. Nominatim  ha priorità = 5"


Usato per oridnare resultati,i valori più alti vengono visualizzati per primi. Nominatim ha priorità = 5
note: only 1 space after "Nominatim"

fix oridnare resultati to ordinare risultati

offtherailz · 2017-05-18T10:53:30Z

web/client/translations/data.en-US

+            "s_wfs_props_label" : "WFS service props",
+            "s_wfs_opt_props_label" : "Optional props",
+            "s_result_props_label": "Result display properties",
+            "s_priority_info": "Used to sort search results, higher values first. Nominatim  results have priority = 5"


1 space only after nominatim

MV88 · 2017-05-18T11:03:28Z

web/client/actions/searchconfig.js

@@ -0,0 +1,53 @@
+/**
+ * Copyright 2017, GeoSolutions Sas.


remove all double * from copyright comments

MV88 · 2017-05-18T11:04:05Z

web/client/components/mapcontrols/searchservicesconfig/ResultsProps.jsx

@@ -0,0 +1,76 @@
+/**
+ * Copyright 2017, GeoSolutions Sas.


MV88 · 2017-05-18T11:04:13Z

web/client/actions/__tests__/searchconfig-test.js

@@ -0,0 +1,51 @@
+/**
+* Copyright 2017, GeoSolutions Sas.


MV88 · 2017-05-18T11:04:25Z

web/client/components/mapcontrols/searchservicesconfig/ServicesList.jsx

@@ -0,0 +1,81 @@
+/**
+ * Copyright 2017, GeoSolutions Sas.


MV88 · 2017-05-18T11:04:34Z

web/client/components/mapcontrols/searchservicesconfig/WFSOptionalProps.jsx

@@ -0,0 +1,67 @@
+/**
+ * Copyright 2017, GeoSolutions Sas.


MV88 · 2017-05-18T11:04:49Z

web/client/components/mapcontrols/searchservicesconfig/__tests__/SearchServiceConfig-test.jsx

@@ -0,0 +1,48 @@
+/**
+* Copyright 2017, GeoSolutions Sas.


MV88 · 2017-05-18T11:05:09Z

web/client/plugins/searchservicesconfig/ToggleButton.jsx

@@ -0,0 +1,43 @@
+/**
+ * Copyright 2017, GeoSolutions Sas.


MV88 · 2017-05-18T11:05:14Z

web/client/reducers/__tests__/searchconfig-test.js

@@ -0,0 +1,78 @@
+/**
+* Copyright 2017, GeoSolutions Sas.


MV88 · 2017-05-18T11:05:20Z

web/client/reducers/searchconfig.js

@@ -0,0 +1,45 @@
+/**
+* Copyright 2017, GeoSolutions Sas.


MV88 · 2017-05-18T11:05:52Z

web/client/translations/data.it-IT

+            "s_wfs_props_label" : "Proprietà WFS service",
+            "s_wfs_opt_props_label" : "Proprietà facoltative",
+            "s_result_props_label": "Proprietà di visualizzazione dei risultati",
+            "s_priority_info": "Usato per oridnare resultati, valori più alti per primi. Nominatim  ha priorità = 5"


fix oridnare resultati to ordinare risultati

offtherailz · 2017-05-18T12:38:01Z

web/client/components/mapcontrols/searchservicesconfig/SearchServices.css

+}
+
+
+#search-serivices-ui .noUi-background {


search-serivices-editor is better, and use a class

offtherailz · 2017-05-18T12:38:46Z

web/client/components/mapcontrols/searchservicesconfig/SearchServices.css

+    border-bottom: 1px solid gray;
+    font-size: larger;
+}
+.confirm-close{


too generic, use specific selector

offtherailz · 2017-05-18T12:39:01Z

web/client/plugins/SearchServicesConfig.jsx

+                                text: <Message msgId="search.cancelbtn" />, className: "btn btn-sm btn-warning confirm-close"}} onConfirm={this.onClose} bsStyle="primary" text={(<Glyphicon glyph={closeGlyph}/>)}/>) : <button onClick={this.onClose} className="close">{closeGlyph ? <Glyphicon glyph={closeGlyph}/> : <span>×</span>}</button>}
+                            }
+                    </span>
+                    <div role="body" id="search-serivices-ui">


use a class if possible

coveralls · 2017-05-18T13:39:14Z

Coverage decreased (-0.08%) to 79.479% when pulling 50829b2 on kappu72:master into 2a9f77a on geosolutions-it:master.

coveralls · 2017-05-18T14:23:22Z

Coverage decreased (-0.09%) to 79.474% when pulling a3d399f on kappu72:master into 2a9f77a on geosolutions-it:master.

Add ui to configure text search services

7425b0d

kappu72 added the pending review label May 18, 2017

offtherailz requested changes May 18, 2017

View reviewed changes

MV88 requested changes May 18, 2017

View reviewed changes

offtherailz requested changes May 18, 2017

View reviewed changes

Fixes on Lore's comments, closes geosolutions-it#1820

50829b2

Configured docs

a3d399f

offtherailz approved these changes May 18, 2017

View reviewed changes

MV88 approved these changes May 18, 2017

View reviewed changes

offtherailz merged commit 27b303b into geosolutions-it:master May 18, 2017

offtherailz removed the pending review label May 18, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ui to configure text search services #1841

Add ui to configure text search services #1841

kappu72 commented May 18, 2017

coveralls commented May 18, 2017

offtherailz May 18, 2017

offtherailz May 18, 2017

offtherailz May 18, 2017

offtherailz May 18, 2017

offtherailz May 18, 2017

offtherailz May 18, 2017

offtherailz May 18, 2017

offtherailz May 18, 2017

offtherailz May 18, 2017

MV88 May 18, 2017

offtherailz May 18, 2017

MV88 May 18, 2017

MV88 May 18, 2017

MV88 May 18, 2017

MV88 May 18, 2017

MV88 May 18, 2017

MV88 May 18, 2017

MV88 May 18, 2017

MV88 May 18, 2017

MV88 May 18, 2017

MV88 May 18, 2017

offtherailz May 18, 2017

offtherailz May 18, 2017

offtherailz May 18, 2017

coveralls commented May 18, 2017

coveralls commented May 18, 2017

		@@ -0,0 +1,403 @@
		/* all this css rules are related to the slider, copy paste from advanced layertree example */

		.noUi-target,

		const WFSOptionalProps = require('../components/mapcontrols/searchservicesconfig/WFSOptionalProps.jsx');


		const SearchServicesConfigPanel = React.createClass({

		}


		#search-serivices-ui .noUi-background {

Add ui to configure text search services #1841

Add ui to configure text search services #1841

Conversation

kappu72 commented May 18, 2017

coveralls commented May 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented May 18, 2017

coveralls commented May 18, 2017