-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set optional drawer menu for share ( see #1632) #1698
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,8 @@ const {Button, Glyphicon, Panel} = require('react-bootstrap'); | |
const Section = require('./drawer/Section'); | ||
|
||
const {partialRight} = require('lodash'); | ||
|
||
const url = require('url'); | ||
const query = url.parse(window.location.href, true).query; | ||
const Menu = connect((state) => ({ | ||
show: state.controls.drawer && state.controls.drawer.enabled, | ||
activeKey: state.controls.drawer && state.controls.drawer.menu || "1", | ||
|
@@ -33,10 +34,28 @@ const Menu = connect((state) => ({ | |
|
||
require('./drawer/drawer.css'); | ||
|
||
/** | ||
* DrawerMenu plugin. Shows a left menu with some pluins rendered inside it (typically the TOC). | ||
* @prop {string} cfg.glyph glyph icon to use for the button | ||
* @prop {boolean} cfg.hideButton. If true, the button to show the drawer menu will be hidden. | ||
* You can force to display it again adding forceDrawer=true in the query string. This is useful in embedded mode. | ||
* @prop {object} cfg.menuButtonStyle Css inline style for the button. Display property will be overridden by the hideButton/forceDrawer options. | ||
* @prop {string} cfg.buttonClassName class for the toggle button | ||
* @prop {object} cfg.menuOptions options for the drawer menu. They can be `docked`, `width. | ||
* @memberof plugins | ||
* @class | ||
* @example | ||
* { | ||
* "name": "DrawerMenu", | ||
* "cfg": { | ||
* "hideButton": true | ||
* } | ||
*/ | ||
const DrawerMenu = React.createClass({ | ||
propTypes: { | ||
items: React.PropTypes.array, | ||
active: React.PropTypes.string, | ||
hideButton: React.PropTypes.bool, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove it, please |
||
toggleMenu: React.PropTypes.func, | ||
id: React.PropTypes.string, | ||
glyph: React.PropTypes.string, | ||
|
@@ -88,7 +107,12 @@ const DrawerMenu = React.createClass({ | |
render() { | ||
return ( | ||
<div id={this.props.id}> | ||
<Button id="drawer-menu-button" style={this.props.menuButtonStyle} bsStyle={this.props.buttonStyle} key="menu-button" className={this.props.buttonClassName} onClick={this.props.toggleMenu} disabled={this.props.disabled}><Glyphicon glyph={this.props.glyph}/></Button> | ||
<Button id="drawer-menu-button" style={ | ||
{ | ||
...this.props.menuButtonStyle, | ||
display: this.props.hideButton && !(query && query.forceDrawer) ? "none" : this.props.menuButtonStyle && this.props.menuButtonStyle.display | ||
} | ||
} bsStyle={this.props.buttonStyle} key="menu-button" className={this.props.buttonClassName} onClick={this.props.toggleMenu} disabled={this.props.disabled}><Glyphicon glyph={this.props.glyph}/></Button> | ||
<Menu single={this.props.singleSection} {...this.props.menuOptions} title={<Message msgId="menu" />} alignment="left"> | ||
{this.renderItems()} | ||
</Menu> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like plugins directly depending from the request. We should use dynamic plugin configuration of plugins to: