Update react-pdf to 1.6.1 Closes #1533 #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarto
reviewed
Mar 14, 2017
| @@ -28,7 +28,7 @@ const PrintOption = React.createClass({ | |||
| }; | |||
| }, | |||
| onChange() { | |||
| this.props.onChange(this.refs.input.getInputDOMNode().checked); | |||
| this.props.onChange(!this.refs.input.props.checked); | |||
There was a problem hiding this comment.
Are you inverting the value?
There was a problem hiding this comment.
Yes, the old one.
getInputDOMNode() just returns null
| @@ -101,7 +101,7 @@ let BackgroundSwitcher = React.createClass({ | |||
| }, | |||
| render() { | |||
| return ( | |||
| <Grid id={this.props.id} className="BackgroundSwitcherComponent" header={this.props.name} fluid={this.props.fluid}>{this.renderBackgrounds()}</Grid> | |||
| <Grid id={this.props.id} className="BackgroundSwitcherComponent" fluid={this.props.fluid}>{this.renderBackgrounds()}</Grid> | |||
There was a problem hiding this comment.
Is header not needed anymore?
There was a problem hiding this comment.
I don't think it ever was, header is not a property of Grid
| @@ -48,42 +48,34 @@ describe("Test the PrintPreview component", () => { | |||
| expect(node).toExist(); | |||
| }); | |||
|
|
|||
| it('creates component and loads pdf', (done) => { | |||
There was a problem hiding this comment.
Why did you remove this test?
There was a problem hiding this comment.
It was testing ReactPDF and it is no longer mockable
mbarto
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.