Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1496 Support to include theme 2.0 #1521

Closed
wants to merge 10 commits into from
Closed

Fix #1496 Support to include theme 2.0 #1521

wants to merge 10 commits into from

Conversation

allyoucanmap
Copy link
Contributor

@allyoucanmap allyoucanmap commented Mar 3, 2017 •
edited by offtherailz
Loading

Fix #1496. Removed styles to support the theme 2.0, merge after Added styles to support the switch from old to new theme geosolutions-it/MapStore2-theme#105 on MapStore2-theme is merged.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 76.926% when pulling a446e4e on allyoucanmap:switch-to-theme2.0 into 10fe76d on geosolutions-it:master.

@offtherailz offtherailz changed the title Fix 1496 Support to include theme 2.0 Fix #1496 Support to include theme 2.0 Mar 6, 2017
offtherailz
offtherailz requested changes Mar 6, 2017
View reviewed changes
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to include also the less style

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 77.114% when pulling 83bc641 on allyoucanmap:switch-to-theme2.0 into 32ffc72 on geosolutions-it:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 77.101% when pulling 6ac5aa2 on allyoucanmap:switch-to-theme2.0 into 32ffc72 on geosolutions-it:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 77.101% when pulling 6ac5aa2 on allyoucanmap:switch-to-theme2.0 into 32ffc72 on geosolutions-it:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 77.101% when pulling 8210c18 on allyoucanmap:switch-to-theme2.0 into 32ffc72 on geosolutions-it:master.

offtherailz
offtherailz requested changes Mar 13, 2017
View reviewed changes
Copy link
Member

@offtherailz offtherailz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No way. We can not include all bootstrap here.
Use a devDependency or go back to previews version

@allyoucanmap allyoucanmap deleted the switch-to-theme2.0 branch March 13, 2017 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offtherailz offtherailz offtherailz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@allyoucanmap @coveralls @offtherailz @simboss @Damianofds