Fix #1249 Added new color ramp in Raster Styler (DEM) #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added new file to extend colorbrewer * Added 5 new elements in color ramp array * Extended colorbrewer with new color scales
offtherailz
requested changes
Jan 26, 2017
| @@ -19,6 +19,9 @@ const {NumberPicker} = require('react-widgets'); | |||
| const ColorRampItem = require('./EqualIntervalComponents/ColorRampItem'); | |||
| const colorsSchema = require("./EqualIntervalComponents/ColorRamp"); | |||
| const colors = require("colorbrewer"); | |||
| const extendColorBrewer = require("./EqualIntervalComponents/ExtendColorBrewer"); | |||
| const assign = require('object-assign'); | |||
| assign(colors, extendColorBrewer); | |||
There was a problem hiding this comment.
You should not assign to a const. Do this assign inline, where needed.
| 12: ["#18c6ca", "#97fe96", "#c5fea5", "#f0feb8", "#fef9bc", "#feee9b", "#f7d580", "#e7cf96", "#d8c9a8", "#c4c1b9", "#e1dfdb", "#ffffff"] | ||
| }, | ||
| Simple: { | ||
| 3: ["#000000", "#ffd400", "#000000"], |
There was a problem hiding this comment.
I should remove #000000 as last color. Keep the last one as #BF7F3F
* fixed ExtendColorRamp * new color palette in Simple color ramp
|
Preview new colors: Styler Simple ramp |
offtherailz
approved these changes
Jan 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below the colors palettes on Weather data (left) and on ETOPO1* (right):
Earth - custom palette
Water - custom palette
Land - custom palette
CDA - ramp from http://soliton.vm.bytemark.co.uk/pub/cpt-city/jm/cd/
Simple - ramp from https://github.com/geoserver/geoserver/blob/master/data/release/styles/dem.sld
*Made with QGis to verify the palettes on topography