Fix #1193. Implementation of Group Manager #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The group manager is accessible from the "Manage Groups" button, as in this mockup. It is implemented using the users look and feel.
|
Only one thing doesn't seems immediate for a user.
Should we indicate somewhere on the top that we are watching users (or groups) page? Like this: |
|
Just set the "new" buttons to green, both for user and group manager as it is in the mockup. |
mbarto
suggested changes
Nov 22, 2016
|
|
||
| require('./style/usercard.css'); | ||
|
|
||
| const UserCard = React.createClass({ |
| }}><Message msgId="usergroups.noUsers"/></div>); | ||
| } | ||
| // NOTE: faking group Id | ||
| return (<UsersTable users={members.sort((u1, u2) => u1.name > u2.name)} onRemove={(user) => { |
There was a problem hiding this comment.
sort is mutating members, can we avoid it?
| const React = require('react'); | ||
| const {Button, Glyphicon, Table, OverlayTrigger, Tooltip} = require('react-bootstrap'); | ||
| const Message = require('../../I18N/Message'); | ||
| var UsersGrid = React.createClass({ |
|
Btw something that tell the user where he is should be added imho. |
|
About the title, it is ok?
|
mbarto
approved these changes
Nov 23, 2016
This allow to distinguish the page. Also added missing i18n (FR and IT)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group manager is accessible from the "Manage Groups" button, as in this mockup:
http://lf.mapstore2.geo-solutions.it/samples/map/manager.html
It is implemented using the users look and feel.
Access from here:
Then you can create, search, edit and delete groups.
Create or Edit
Note: Editing allows to change only the user members, not group name or description (GeoStore do not provide this functionality).
delete