fetching the list of formats is disabled for a no-vendor WMS service #10480 #10594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowheat02
changed the title
offtherailz
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
I added a unit test (please always, in this case was relatively easy for button)
and improved readability and maintainability by putting in common a variable
. Please @rowheat02 look at it.
I approve the PR.
offtherailz
reviewed
Oct 4, 2024
web/client/components/catalog/editor/AdvancedSettings/__tests__/RasterAdvancedSettings-test.js
Outdated
Show resolved
Hide resolved
…_/RasterAdvancedSettings-test.js
|
@ElenaGallo, could you please test this on DEV ? Thank you |
offtherailz
added
the
BackportNeeded
|
Test passed, @rowheat02 please backport to 2024.02.xx. Thanks |
rowheat02
added a commit
to rowheat02/MapStore2
that referenced
this pull request
Oct 8, 2024
tdipisa
pushed a commit
that referenced
this pull request
Oct 8, 2024
tdipisa
removed
the
BackportNeeded
offtherailz
pushed a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #10480
In case of Server type No Vendor the refresh and format buttons are enabled in Advanced Settings. Disabled only for CSW.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
#10480
What is the current behavior?
#10480
What is the new behavior?
For services other than CSW, refresh button and buttons on the format section are enabled while the Server Type is No Vendor.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information