Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10552 various enhancements #10554

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Sep 18, 2024

Description

Improved configuration for

  • Attribution plugin
  • Footer plugin
  • build
  • translations

add svgs

  • headphones.svg
  • triangle-top.svg

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

Fix #10552

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C125-AUSTROCONTROL-2024-SUPPORT labels Sep 18, 2024
@MV88 MV88 added this to the 2024.02.00 milestone Sep 18, 2024
@MV88 MV88 requested a review from tdipisa September 18, 2024 11:16
@MV88 MV88 self-assigned this Sep 18, 2024
@tdipisa tdipisa requested review from offtherailz and removed request for tdipisa September 18, 2024 11:17
@offtherailz offtherailz merged commit cd80905 into geosolutions-it:master Sep 19, 2024
6 checks passed
@offtherailz
Copy link
Member

@ElenaGallo, could you please test this on DEV ? Thank you.
No particular testing in reality. Maybe check the footer and attribution plugins still work as previously designed, and the icons of mapstore are correctly used.

@ElenaGallo
Copy link
Contributor

@MV88 I noticed that the data export button is always visible in the footer, even when a new map is opened.
footer

@MV88
Copy link
Contributor Author

MV88 commented Sep 19, 2024

i do not see it on DEV
https://dev-mapstore.geosolutionsgroup.com/mapstore/#/viewer/new

image

@ElenaGallo
Copy link
Contributor

Test passed @MV88 please backport to 2024.02.xx. Thanks

MV88 added a commit to MV88/MapStore2 that referenced this pull request Sep 20, 2024
tdipisa pushed a commit that referenced this pull request Sep 20, 2024
* Fix #10552 various enhancements (#10554)

* updating also alt attribute
offtherailz pushed a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C125-AUSTROCONTROL-2024-SUPPORT enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin enhancements and CI upgrades for template build
3 participants