#10544: fix Embedded maps - details loads panel even if the details attribute value is NODATA #10548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the details attribute value is NODATA Description: - adding check of no data condition for show/hide details panel in toolbar
1 task
MV88
approved these changes
Sep 16, 2024
MV88
added
the
BackportNeeded
|
@ElenaGallo please test it in DEV and let us know if it possible to backport it to 2024.02.xx |
|
Test passed, @mahmoudadel54 please backport it to 2024.02.xx, thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Sep 18, 2024
…f the details attribute value is NODATA (geosolutions-it#10548) Description: - adding check of no data condition for show/hide details panel in toolbar
Backport is done --- > #10558 |
tdipisa
removed
the
BackportNeeded
offtherailz
pushed a commit
that referenced
this pull request
Oct 18, 2024
…ttribute value is NODATA (#10548) Description: - adding check of no data condition for show/hide details panel in toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, adding check of no data condition for show/hide details panel in toolbar has been implemented to fix the issue.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10544
What is the current behavior?
#10544
What is the new behavior?
The details panel is hidden in the toolbar for embeded maps if the details attribute value is NODATA.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information