-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #10506 Adding possibility to fetch legends images using Bearer token #10507
Merged
allyoucanmap
merged 8 commits into
geosolutions-it:master
from
MV88:10506_get_leegend_graphic_bearer
Aug 19, 2024
Merged
Fix #10506 Adding possibility to fetch legends images using Bearer token #10507
allyoucanmap
merged 8 commits into
geosolutions-it:master
from
MV88:10506_get_leegend_graphic_bearer
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using Bearer token
allyoucanmap
requested changes
Aug 13, 2024
* removed async await and fetch * changed way of using token in case of bearer auth
@allyoucanmap can you please review this PR again on the light of latest changes? Can you approve? |
allyoucanmap
approved these changes
Aug 19, 2024
@ElenaGallo please test this fix on DEV, thanks |
@ElenaGallo in our case you can simply test a layer that has legend that is visible and not broken by this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding possibility to request images legend using bearer token
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Fix #10506
What is the new behavior?
now if the legend url needs to use a Bearer token it switches to a SecureImage component that fetches the token from state, so this will work only if the user is logged in (because the legends are behind a secured geoserver, and authentication is needed)
otherwise it will show legend not available
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
I also remove the line
addAuthenticationParameter(url, query);
because it was doing nothing placed there (returning a value not used)