[Backport 2024.01.xx]: #10136: Search for Map CRS coordinates (#10220, #10305) #10317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t#10220) * geosolutions-it#10136: Search for Map CRS coordinates Description: - handle current map CRS coordinate search - Add new component for current map CRS coordinates search - create a util function for getting extent based on extent to validate the mapCRS extent in case of seach by mapCRS coords - write some unit tests accroding the new added code + changes * geosolutions-it#10136: Search for Map CRS coordinates Description: - add translations * geosolutions-it#10136: Search for Map CRS coordinates Description: - resolve review comments - handle projection bounds range * geosolutions-it#10136: Search for Map CRS coordinates Description: - fix FE failure by creating a custom component for DecimalCoordinateEditorSearch * geosolutions-it#10136: Search for Map CRS coordinates Description: - revert change in DecimalCoordinateEditor file to keep it as it is in MS * geosolutions-it#10136: Search for Map CRS coordinates Description: - resolve review comments * geosolutions-it#10136: Search for Map CRS coordinates Description: - resolve review comments - fix issue of not zooming to 0,0 for map crs option - don't allow to change coords inputs beyond the allowable crs extent * geosolutions-it#10136: Search for Map CRS coordinates Description: - resolve review comments * geosolutions-it#10136: Search for Map CRS coordinates Description: - fix clearing marker in switch to different crs * geosolutions-it#10136: Search for Map CRS coordinates Description: - fix issue in switch to aeronautical inputs then switch to map crs coord search * geosolutions-it#10136: Search for Map CRS coordinates Description: - resolve review comments * geosolutions-it#10136: Search for Map CRS coordinates Description: - resolve review comments * geosolutions-it#10136: Search for Map CRS coordinates Description: - resolve jumping cursor to last number in input number in change - Rename component to CRSCoordinateEditor * geosolutions-it#10136: Search for Map CRS coordinates Description: - handle localization into onFocus event in CRS coordinate editor * geosolutions-it#10136: Search for Map CRS coordinates Description: - remove util function and its test and add its logic to onFocus function directly to fix FE failure * geosolutions-it#10136: Search for Map CRS coordinates Description: - revert changes of onFocus, onBlur for IntlNumberFormControl * geosolutions-it#10136: Search for Map CRS coordinates Description: - fix issue in lon field
…t#10305) * geosolutions-it#10136: Search for Map CRS coordinates Description: - resolve a threshold in CRS coordinate in switch * geosolutions-it#10136: Search for Map CRS coordinates Description: - resolve not update the X/Y coods in case switch between map crs by storing the currentMapCRS into coordinate object
6 tasks
This was referenced May 14, 2024
tdipisa
requested changes
May 14, 2024
There was a problem hiding this comment.
@mahmoudadel54 can you please double check the following?
Comparing with:
#10220
changes to the CoordinatesSearch.js here don't seems the same of:
| @@ -108,6 +139,7 @@ const CoordinatesSearch = ({ | |||
| onZoomToPoint, | |||
| onChangeCoord, | |||
| defaultZoomLevel, | |||
| currentMapCRS, | |||
There was a problem hiding this comment.
| @@ -131,9 +163,30 @@ const CoordinatesSearch = ({ | |||
|
|
|||
| const changeCoordinates = (coord, value) => { | |||
| onChangeCoord(coord, parseFloat(value)); | |||
| // set current map crs to coordinate object | |||
There was a problem hiding this comment.
| if (!areValidCoordinates()) { | ||
| onClearCoordinatesSearch({owner: "search"}); | ||
| } | ||
| // if there is mapCRS available --> calculate X/Y values by reproject to display in case switch to MapCRS |
There was a problem hiding this comment.
| @@ -194,7 +249,8 @@ CoordinatesSearch.propTypes = { | |||
| onClearCoordinatesSearch: PropTypes.func, | |||
| onZoomToPoint: PropTypes.func, | |||
| onChangeCoord: PropTypes.func, | |||
| defaultZoomLevel: PropTypes.number | |||
| defaultZoomLevel: PropTypes.number, | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Backport 2024.01.xx]: #10136: Search for Map CRS coordinates (#10220, #10305)