#10167: Set OL as default mapType also for 2D map in mobile #10267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obile Description: - set ol as a default for 2d map for mobile - edit the scale bar style to be at the left-bottom
mahmoudadel54
added
enhancement
Internal
BackportNeeded
|
@allyoucanmap @ElenaGallo let's wait for 2024.01.00 before backporting this. |
1 task
allyoucanmap
requested changes
May 15, 2024
…obile Description: - remove all related code using ol-mobile - add the required style for ol-scale-line
…obile Description: - remove unused props from openlayers/scalebar.jsx - edit in ol.less style
allyoucanmap
approved these changes
May 16, 2024
|
@ElenaGallo please test on dev and let us know if we can backport, thanks |
|
Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
May 17, 2024
Backport is done ---> #10337 |
allyoucanmap
pushed a commit
that referenced
this pull request
May 17, 2024
ElenaGallo
removed
the
BackportNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, setting OL as a default for 2d map for mobile is done plus editing the scale bar style to be at the left-bottom by adding a custom class 'ol-mobile' for scale bar.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10167
What is the current behavior?
#10167
What is the new behavior?
The default map for 2D is openlayers on mobile mode.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information