Fixed #1011 : fixed several bugs on permission editor #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MV88
commented
Sep 23, 2016
•
MV88
commented
- Some translations are missing and they also should be internationalized.
- If the user isn't the owner of the map --> hide permission editor
- The groups spinner should turn off if no available groups is left
Gnafu
suggested changes
Sep 28, 2016
| @@ -123,7 +123,7 @@ const MetadataModal = React.createClass({ | |||
| }, | |||
| componentDidUpdate(prevProps) { | |||
| if (this.props.show && !prevProps.show) { | |||
| if (this.props.displayPermissionEditor) { | |||
| if (this.props.displayPermissionEditor && this.props.user.name === this.props.map.owner) { | |||
There was a problem hiding this comment.
ADMIN role users should be able to edit map permissions even if they are not owners
| @@ -157,7 +157,7 @@ const MetadataModal = React.createClass({ | |||
| this.refs.thumbnail.updateThumbnail(this.props.map, metadata); | |||
| }, | |||
| renderPermissionEditor() { | |||
| if (this.props.displayPermissionEditor) { | |||
| if (this.props.displayPermissionEditor && this.props.user.name === this.props.map.owner) { | |||
There was a problem hiding this comment.
Same as above, ADMIN users must be able to edit permissions
| @@ -30,18 +30,26 @@ describe('This test for MetadataModal', () => { | |||
| expect(metadataModalItem).toExist(); | |||
|
|
|||
| const metadataModalItemDom = ReactDOM.findDOMNode(metadataModalItem); | |||
| expect(metadataModalItemDom).toNotExist(); | |||
| expect(metadataModalItemDom).toExist(); | |||
There was a problem hiding this comment.
please test that it is not visible
Gnafu
approved these changes
Oct 5, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.