-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8871 Improve getLegendGraphic compatibility for print #10041
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offtherailz
added
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Mar 7, 2024
allyoucanmap
approved these changes
Mar 7, 2024
@ElenaGallo please test on dev and let us know if we can backport on 2024.01.xx, thanks |
offtherailz
added a commit
to offtherailz/MapStore2
that referenced
this pull request
Mar 7, 2024
Test passed, @offtherailz please backport on 2024.01.xx, thanks |
allyoucanmap
pushed a commit
that referenced
this pull request
Mar 11, 2024
ElenaGallo
removed
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Mar 11, 2024
offtherailz
added a commit
to offtherailz/MapStore2
that referenced
this pull request
Apr 10, 2024
offtherailz
added a commit
to offtherailz/MapStore2
that referenced
this pull request
Apr 10, 2024
12 tasks
offtherailz
pushed a commit
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes what reported in #8871 , making the request exclude the LANGUAGE parameter if not necessary, making the getLegendGraphic compatible with servers that added some localization for GeoServer's UI that do not tollerate the language parameter.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#8871
What is the new behavior?
Fix #8871
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information