Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating backgrounds to 512 tile size #10037

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Updating backgrounds to 512 tile size #10037

merged 2 commits into from
Mar 7, 2024

Conversation

tdipisa
Copy link
Member

@tdipisa tdipisa commented Mar 6, 2024

Description

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#9382

What is the new behavior?

Default background layers now use tiles of size 521x512.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@tdipisa tdipisa marked this pull request as draft March 6, 2024 17:16
@tdipisa tdipisa added this to the 2024.01.00 milestone Mar 6, 2024
@tdipisa tdipisa linked an issue Mar 6, 2024 that may be closed by this pull request
6 tasks
@tdipisa tdipisa self-assigned this Mar 6, 2024
@tdipisa tdipisa requested a review from allyoucanmap March 6, 2024 17:21
@tdipisa tdipisa marked this pull request as ready for review March 6, 2024 17:22
@tdipisa tdipisa changed the title Updating backgrounds at 512 tile size Updating backgrounds to 512 tile size Mar 6, 2024
@allyoucanmap allyoucanmap merged commit 72a7217 into master Mar 7, 2024
6 checks passed
@allyoucanmap allyoucanmap added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 7, 2024
@allyoucanmap
Copy link
Contributor

@ElenaGallo please test this on dev and let us know if we can backport on 2024.01.xx, thanks

@tdipisa
Copy link
Member Author

tdipisa commented Mar 7, 2024

@ElenaGallo please test on then together with other connected issues:
#9361
#9379
#9464

@ElenaGallo
Copy link
Contributor

Test passed, @tdipisa please backport on 2024.01.xx, thanks

@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 12, 2024
@tdipisa
Copy link
Member Author

tdipisa commented Mar 12, 2024

Done, waiting for your review #10057 @allyoucanmap

@tdipisa tdipisa deleted the tdipisa-patch-2 branch March 26, 2024 09:26
offtherailz pushed a commit to offtherailz/MapStore2 that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default tile size for GS OSM layers to 512
3 participants